Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lib): resolve unused warning #3344

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Oct 12, 2023

Adds cfg feature attributes to resolve unused warnings, which occur in each features and the combinations, and ci config to check unused_imports and dead_code.

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@seanmonstar seanmonstar merged commit cd6af66 into hyperium:master Oct 12, 2023
19 checks passed
@tottoto tottoto deleted the unused-warning branch October 12, 2023 21:05
@tottoto tottoto changed the title refactor: resolve unused warning refactor(lib): resolve unused warning Oct 12, 2023
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 12, 2024
In CI, check unused_imports and dead_code
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 16, 2024
In CI, check unused_imports and dead_code

Signed-off-by: Sven Pfennig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants